Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/composite editor #1

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Conversation

tortmayr
Copy link
Collaborator

Add composite editor and upgrade framework

Add composite editor:

  • Introduce new composite-editor package
  • Register composite-editor as default open handler
  • Composite editor shows different subeditors for the same file in a tabpanel and is enables for
    • Entities (Form/Code)
    • Relationships (Form/Code)
    • Systemdiagram (Diagarm/Code)
    • Mapping diagram (Diagram/Code)

Upgrade Frameworks:

  • Update to GLSP 2.2.1 - the latest GLSP version

martin-fleck-at and others added 7 commits July 5, 2024 14:26
Upgrade Frameworks:
- Update to Theia 1.49.1 - the latest community release
- Update to GLSP 2.2.0 - the latest GLSP version
- Update to Node 20 - only affects CI workflows

Improve Tools and Toolbox in Diagrams:
- Wrap tool functionality up into their own tool modules
- Define default tool as select tool
- Create new tool for creating an entity in the system diagram
- Ensure newly created files are put into the correct sub-folder
- Render toolbox to explicitly list tools and give toolbox better style

Co-authored-by: Tobias Ortmayr <[email protected]>
From GitHub: The macos-11 label has been deprecated and will no longer
be available after 28 June 2024.
Updated e2e-tests package.json so playwright is not installed in prepare phase.
Add composite editor:
- Introduce new composite-editor package
- Register composite-editor as default open handler
- Composite editor shows different subeditors for the same file in a tabpanel and is enables for 
   - Entities (Form/Code)
   - Relationships (Form/Code)
   - Systemdiagram (Diagarm/Code)
   - Mapping diagram (Diagram/Code)


Upgrade Frameworks:
- Update to GLSP 2.2.1 - the latest GLSP version
@tortmayr tortmayr marked this pull request as draft July 28, 2024 08:56
Copy link

Unit Test Results

 1 files  10 suites   37s ⏱️
71 tests 71 ✅ 0 💤 0 ❌
72 runs  72 ✅ 0 💤 0 ❌

Results for commit e4e83fd.

@tortmayr
Copy link
Collaborator Author

Known issues:

With the composite editor both the graphical/form and text editor are open at once.
Potentially also the properties view is currently open.
This causes sync issues on change and save

  • Changes in the text editor are executed after every keyboard stroke -> this means the graphical editor could receive updates
    for an incomplete/faulty model
  • Updates are not debounced -> text editing causes a lot of intermediate updates in the graphical editor
  • The graphical diagram has its own commandstack that can get out of sync with a mix of graphical and texting
  • Editing something essential in the text editor like the entity property/id of an entry can cause a crash of the graphical server
  • For the form editor changes and undo/redo are only applied locally and synced with the model service on save

Side issue that should be fixed as part of the stabilization efforts

  • The CSS of the form editor leaks into the main application and overrides things like font size and icon spacing
  • -> Whenever a form editor is open the styling of the Theia application e.g. explorer view changes. Once closed its resets to the original values

@tortmayr tortmayr requested a review from martin-fleck-at July 28, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants